-
Notifications
You must be signed in to change notification settings - Fork 8.5k
feat(slo): Add index sorting on SLI and split per day #244978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
|
|
Pinging @elastic/actionable-obs-team (Team:actionable-obs) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
| index_patterns: [SLI_INDEX_TEMPLATE_PATTERN], | ||
| composed_of: [SLI_COMPONENT_TEMPLATE_MAPPINGS_NAME, SLI_COMPONENT_TEMPLATE_SETTINGS_NAME], | ||
| priority: 500, | ||
| priority: 600, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To override the previous index template matching on broader index pattern, e.g. .slo-observability.sli-* instead of .slo-observability.sli-v3.6* like now
Resolves #244697
Resolves #244678
Summary
This PR bumps the SLO resources version to 3.6, meaning only new SLOs or SLOs updated with a breaking change or reseted will use the new index settings and ingest pipelines.
This PR changes the date_index_name date rounding processor to daily instead of monthly. Customers can always use
slo-rollup-global@customingest pipeline to override this settings if necessary.We also added index sorting on the SLI index settings using [id, revision, instanceId] which are the first ordered keys referenced by the summary transform. This will help tremendously the composite aggs made by this transform.
On the overview cluster, where each daily index has about 20M documents with a size of 20GB, the write_load decreased compared to the write_load of previous indices who were not using the index (but who had way more documents, e.g. monthly instead of daily rollup), so we cannot really compare apples to apples... But at least the overview cluster is not overwhelmed with this settings.
And from @henrikno testing with a 300gb index, the query ran by the summary transform went from 2min to 2s using this settings.
Testing
Release notes